Adopt swift-certificates 0.6.0
#6528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
Need to bump swift-asn1 to 0.8.0 as well. @swift-ci please smoke test |
dnadoba
requested review from
MaxDesiatov,
abertelrud,
neonichu and
tomerd
as code owners
yim-lee
force-pushed
the
dn-certificates-0.6.0
branch
2 times, most recently
from
d426634 to
b81417c
Compare
|
Change of mind. Will update swift-system separately. swiftlang/swift#65850 |
yim-lee
approved these changes
May 16, 2023
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
tomerd
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift-certificateshas released a new version with a couple breaking changes:PolicySetis deprecated in favour of a new result builder DSL and returns an opaqueVerifierPolicy. Verifier is now generic over the concreteVerifierPolicyand uses the@PolicyBuilderto constructs its policy.Certificate.Extensionsnow gracefully fails extension serialization but now needs to returnResult<Certificate.Extensions, any Error>.This PR adopts these new changes.