Skip to content

Conversation

@neonichu
Copy link
Contributor

@neonichu neonichu commented Dec 8, 2022

This reenables several disabled tests and reverts an incorrect change to the bootstrap script.

These tests were disabled but proven working again.

rdar://101868275
This reverts commit 59dc518.

This change was incorrect, `bootstrap` is in fact creating a symlink to the inferior compiler for testing, so overriding `SWIFT_EXEC` is incorrect.
@neonichu neonichu requested a review from abertelrud as a code owner December 8, 2022 06:30
@neonichu neonichu self-assigned this Dec 8, 2022
@neonichu neonichu requested review from elsh and tomerd as code owners December 8, 2022 06:30
@neonichu
Copy link
Contributor Author

neonichu commented Dec 8, 2022

@swift-ci please smoke test

@neonichu
Copy link
Contributor Author

neonichu commented Dec 8, 2022

Looks like we have some bit rot in the FunctionalTests that were disabled?

@neonichu
Copy link
Contributor Author

neonichu commented Dec 8, 2022

@swift-ci please smoke test

@neonichu neonichu enabled auto-merge (squash) December 8, 2022 08:11
@neonichu neonichu merged commit c6faab7 into main Dec 8, 2022
@neonichu neonichu mentioned this pull request Dec 9, 2022
@neonichu neonichu deleted the re-enable-tests branch December 9, 2022 00:20
neonichu added a commit that referenced this pull request Dec 9, 2022
This reverts commit c6faab7.

The failure showed up again in #5950, so it's not actually gone.
neonichu added a commit that referenced this pull request Dec 9, 2022
This reverts commit c6faab7.

The failure showed up again in #5950, so it's not actually gone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants