Make sure we actually use swift-driver #5885
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tries to use the swift-driver built during the first-stage for the "fake" toolchain we're constructing for bootstrapping. Basically a variation on #5842. Trying first whether it is sufficient to just have the symlink, if not we should be able to combine the approach from #5842 and this together.
|
@swift-ci please smoke test |
|
I guess either way, we also still have the mystery on why this is failing for the self-hosted macOS job :/ |
|
Doesn't look as if the driver existing is enough here. Going to try out bringing my change to bootstrap into the other PR. |
|
Oh right, this can't work yet since the revert of #4213 is only on a branch, so we're currently not using the fake toolchain during |
|
@swift-ci please smoke test |
|
Closing, this doesn't solve the problem we're seeing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to use the swift-driver built during the first-stage for the "fake" toolchain we're constructing for bootstrapping. Basically a variation on #5842.
Trying first whether it is sufficient to just have the symlink, if not we should be able to combine the approach from #5842 and this together.