Test parent directory of .netrc file is writable before using it #4075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yim-lee
requested review from
abertelrud,
elsh,
neonichu and
tomerd
as code owners
This was referenced Feb 1, 2022
neonichu
approved these changes
Feb 1, 2022
Contributor
Author
|
@swift-ci please smoke test |
https://ci.swift.org/job/swift-PR-source-compat-suite-debug/4058/ ``` $ sandbox-exec -f /Users/buildnode/jenkins/workspace-private/swift-source-compat-suite-sandbox/sandbox_package.sb /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-debug/build/compat_macos/install/toolchain/usr/bin/swift package --disable-sandbox -C /Users/buildnode/jenkins/workspace/swift-PR-source-compat-suite-debug/swift-source-compat-suite/project_cache/GRDB.swift clean warning: '--chdir/-C' option is deprecated; use '--package-path' instead warning: Failed to load .netrc file at /Users/buildnode/.netrc. Error: unreadableFile(<AbsolutePath:"/Users/buildnode/.netrc">) error: other(1) ``` Not sure if the `other(1)` error is `.netrc` related. Trying to see if this code change will fix it. rdar://88308095
…ationDirectory sharedConfigurationDirectory is a custom path iff defaultDirectory is non nil (in this case it's only ever nil when an error occurs while reading/writing the directory) and defaultDirectory != sharedConfigurationDirectory
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
Added 4f03f1b, which I think is the real fix, so please review again. |
tomerd
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ci.swift.org/job/swift-PR-source-compat-suite-debug/4058/
Not sure if the
other(1)error is.netrcrelated. Trying to see ifthis code change will fix it.