[5.6] Make sure that NSTemporaryDirectory() is included when writableTemporaryDirectory is set.
#3921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eTemporaryDirectory` is set. (swiftlang#3918) It seems that `TSCBasic.determineTempDirectory()` lets environment variables override the temporary directory, which might be alright for the process itself but not necessarily for spawned subprocesses. If the subprocess uses NSTemporaryDirectory(), then that still won't be covered by the sandbox. This change makes the sandbox cover the regular "/tmp" and NSTemporaryDirectory() paths. If environment entries are used to set other temporary directories in the subprocess, then the calling code should pass those to the `writableDirectories` parameter. rdar://86150592 (cherry picked from commit 5546a97 and 3ba3305)
abertelrud
added
5.6
ready
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
Self-hosted is failing because there is no 5.6 toolchain yet (it's not a required build though). |
tomerd
approved these changes
Dec 9, 2021
abertelrud
deleted the
eng/adjust-sandbox-to-always-include-nstemporarydirectory-when-tmp-dir-is-writable-5.6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 5.6 cherry-pick of #3918 and its refinement #3920.
This change makes the sandbox cover the regular "/tmp" and NSTemporaryDirectory() paths. If environment entries are used to set other temporary directories in the subprocess, then the calling code should pass those to the
writableDirectoriesparameter.rdar://86150592
(cherry picked from commit 5546a97 and 3ba3305)