relax stricter validation to warning to allow transition #3713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: recent change to SwiftPM introduced strickter validation of dependencies uniquness to address undefined behavior. however, we want to allow users some times to adjust before making a breaking change changes: update the validation to emit a warning instead of error under the specific condition the previous behavior incorrectly ignored!
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
Contributor
Author
|
@swift-ci please smoke test |
tomerd
changed the title
tomerd
added
the
ready
abertelrud
approved these changes
Sep 3, 2021
neonichu
approved these changes
Sep 3, 2021
mattt
pushed a commit
to mattt/swift-package-manager
that referenced
this pull request
Sep 16, 2021
…3713) motivation: recent change to SwiftPM introduced strickter validation of dependencies uniquness to address undefined behavior. however, we want to allow users some times to adjust before making a breaking change changes: update the validation to emit a warning instead of error under the specific condition the previous behavior incorrectly ignored!
tomerd
added a commit
to swiftlang/swift-source-compat-suite
that referenced
this pull request
Sep 20, 2021
underlying issue was addressed in swiftlang/swift-package-manager#3713
Contributor
Author
|
this was done to help with https://bugs.swift.org/browse/SR-15146, also see Kitura/Kitura#1559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: recent change to SwiftPM introduced stricter validation of dependencies uniquness to address undefined behavior. however, we want to allow users some times to adjust before making a breaking change
changes: update the validation to emit a warning instead of error under the specific condition the previous behavior incorrectly ignored!