deprecate static APIs with inefficient defaults #3657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
Contributor
Author
|
needs #3656 first |
tomerd
force-pushed
the
refactor/static-apis
branch
from
731449c to
06d1ac5
Compare
Contributor
Author
|
@swift-ci please smoke test |
neonichu
reviewed
Aug 10, 2021
motivation: configuration work has pointed out that some of the static APIs (which are questionable to begin with) use inefficient defaults changes: * deprecate Workspace.create, Workspace.loadRootGraph, PackageBuilder.loadRootPackage, ManifestLoader.loadRootManifest and replace them with instance methods on workspace * add a simple constructor to workspace, that uses the host toolchain by default * adjust call-sites, test and examples
tomerd
force-pushed
the
refactor/static-apis
branch
from
06d1ac5 to
bfa5ae9
Compare
tomerd
commented
Aug 10, 2021
Contributor
Author
|
@swift-ci please smoke test |
abertelrud
reviewed
Aug 10, 2021
abertelrud
approved these changes
Aug 11, 2021
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: configuration work has pointed out that some of the static APIs use inefficient defaults
changes: