Simplify minimum deployment target on Darwin platforms (still requiring macOS 10.15+, adding iOS 13+) #3557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the deployment targets on Darwin platforms, setting the minimum deployment target to macOS 10.15 and iOS 13 or later on Darwin platforms. The environment variables were needed during a transitional phase. Note that non-Darwin platforms are unaffected.
Contributor
Author
|
@swift-ci please smoke test |
tomerd
approved these changes
Jun 15, 2021
neonichu
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the deployment targets on Darwin platforms, setting the minimum deployment target to macOS 10.15 and iOS 13 or later on Darwin platforms. The environment variables were needed during a transitional phase, and SwiftPM already required macOS 10.15 or later on macOS. Note that non-Darwin platforms are unaffected.
Motivation:
This simplifies the logic while keeping the same macOS 10.15 dependency, and aligns SwiftPM with the ToolsSupportCore requirements in swiftlang/swift-tools-support-core#225.
See comment in #3552 (comment)
Modifications:
Set macOS 10.15 and iOS 13 as minimum deployment targets.
Result:
No change for macOS, v13 required for iOS.