Throw error when tests are found directly under Tests #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If tests are directly under Tests directory, swift test will fail with fail because it tries to unwrap a nil value. Fixed it by adding proper guard statements
Contributor
|
I verified this fixes the crash, merging since it is definitely a monotonic improvement. @mxcl can you review if there is anything else needed here? |
Contributor
|
Maybe it also would be nice to warn users that there some unused |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If tests are directly under Tests directory,
swift testwill fail because it tries to unwrap anilvalue.Fixed it by throwing
TestsExecutableNotFounderror.