PackageModel: add windows to the list of known platforms
#2869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
Member
Author
|
CC: @tomerd |
Member
Author
|
@swift-ci please smoke test |
Contributor
|
lgmt, but not sure about any implications. @neonichu @abertelrud? |
tomerd
approved these changes
Aug 14, 2020
Member
Author
|
@swift-ci please smoke test Linux platform |
Member
Author
|
@swift-ci please smoke test |
Ensure that Windows is listed as a known platform. Failure to acknowledge that will result in failures to map the platform from the string representation.
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
This is required for swiftlang/swift-llbuild#678 |
neonichu
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that Windows is listed as a known platform. Failure to
acknowledge that will result in failures to map the platform from the
string representation.