Skip to content

Fix docker-utils #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2020
Merged

Fix docker-utils #2767

merged 1 commit into from
Jun 5, 2020

Conversation

@neonichu
Copy link
Contributor

@neonichu neonichu commented May 27, 2020

  • paths to swift-driver and yams were missing
  • the dispatch and foundation dir arguments became mandatory on
    non-macOS, this makes them optional again

@neonichu
Fix docker-utils
996ac4b 
- paths to swift-driver and yams were missing
- the dispatch and foundation dir arguments became mandatory on
non-macOS, this makes them optional again
@neonichu neonichu requested review from DougGregor and abertelrud May 27, 2020 23:09
@neonichu
Copy link
Contributor Author

neonichu commented May 27, 2020

@swift-ci please smoke test

DougGregor
DougGregor approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DougGregor DougGregor mentioned this pull request May 29, 2020
Merged
abertelrud
abertelrud approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@abertelrud abertelrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with this script, but the diffs look reasonable to me.

@neonichu
Copy link
Contributor Author

neonichu commented Jun 2, 2020

@swift-ci please smoke test

@neonichu neonichu merged commit 8ea9f27 into swiftlang:master Jun 5, 2020
@neonichu neonichu deleted the update-docker-utils branch June 5, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DougGregor DougGregor DougGregor approved these changes

@abertelrud abertelrud abertelrud approved these changes

@aciidgh aciidgh Awaiting requested review from aciidgh

@friedbunny friedbunny Awaiting requested review from friedbunny

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neonichu @DougGregor @abertelrud