Skip to content

Conversation

@aciidgh
Copy link
Contributor

@aciidgh aciidgh commented Feb 19, 2020

…tion

rdar://problem/59563902

@aciidgh
Copy link
Contributor Author

aciidgh commented Feb 19, 2020

@swift-ci smoke test

@aciidgh aciidgh merged commit 12bf7e7 into swiftlang:master Feb 20, 2020
@aciidgh aciidgh deleted the target-dep branch February 20, 2020 02:34
@tonyarnold
Copy link
Contributor

Did this PR deliberately elide the .when(configuration: .release) syntax?

I could really use that functionality, and it's in the proposal for SE-0273.

@aciidgh
Copy link
Contributor Author

aciidgh commented Jun 29, 2020

yah, configuration conditionals aren't implemented yet at the build system level but SE-0273 should state that explicitly instead of saying "Implemented (Swift 5.3)".

@tonyarnold
Copy link
Contributor

Ok, great to know - thanks, Ankit!

Do the changes need to happen in llbuild? Is there an SR I can watch (or create) to add this support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants