Remove release-mode dead-strip #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
keith
added a commit
to keith/swift-package-manager
that referenced
this pull request
Feb 14, 2022
In the past it was unsafe to pass -dead_strip because there was some swift metadata that could be stripped. It seems that at this point all of those cases are either fixed or marked as @llvm.used, so passing these flags should safely reduce binary size in some cases. If there are other cases where this isn't safe we should likely annotate them as @llvm.used anyways. Related: https://bugs.swift.org/browse/SR-521 swiftlang#215
keith
added a commit
to keith/swift-package-manager
that referenced
this pull request
Feb 15, 2022
In the past it was unsafe to pass -dead_strip because there was some swift metadata that could be stripped. It seems that at this point all of those cases are either fixed or marked as @llvm.used, so passing these flags should safely reduce binary size in some cases. If there are other cases where this isn't safe we should likely annotate them as @llvm.used anyways. Related: https://bugs.swift.org/browse/SR-521 swiftlang#215
tomerd
pushed a commit
that referenced
this pull request
Feb 16, 2022
motivation: In the past it was unsafe to pass -dead_strip because there was some swift metadata that could be stripped. It seems that at this point all of those cases are either fixed or marked as @llvm.used, so passing these flags should safely reduce binary size in some cases. If there are other cases where this isn't safe we should likely annotate them as @llvm.used anyways. Related: https://bugs.swift.org/browse/SR-521 #215 changes: * Add -dead_strip / --gc-sections for release builds * Add --disable-dead-strip flag * Add CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://bugs.swift.org/browse/SR-521