Add new manifest option to swift package init
#2106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
aciidgh
approved these changes
Apr 30, 2019
Contributor
aciidgh
left a comment
aciidgh
left a comment
There was a problem hiding this comment.
LGTM. Just needs linuxmain.
This will just generate a manifest in the current directory. The contents will be the same as for initializing a library package. That means the contents will likely not match the filesystem layout, but I think that is OK, this will still make it easier to add a manifest to an existing project. We can improve it in the future and make the generated content based on what is actually there on the filesystem. rdar://problem/50347943
neonichu
force-pushed
the
init-with-manifest
branch
from
ec13dd9 to
855a1f3
Compare
Contributor
Author
|
@swift-ci please smoke test |
neonichu
added a commit
to neonichu/swift-package-manager
that referenced
this pull request
May 1, 2019
This will just generate a manifest in the current directory. The contents will be the same as for initializing a library package. That means the contents will likely not match the filesystem layout, but I think that is OK, this will still make it easier to add a manifest to an existing project. We can improve it in the future and make the generated content based on what is actually there on the filesystem. rdar://problem/50347943
neonichu
added a commit
that referenced
this pull request
May 1, 2019
This will just generate a manifest in the current directory. The contents will be the same as for initializing a library package. That means the contents will likely not match the filesystem layout, but I think that is OK, this will still make it easier to add a manifest to an existing project. We can improve it in the future and make the generated content based on what is actually there on the filesystem. rdar://problem/50347943
aemino
pushed a commit
to aemino/swift-package-manager
that referenced
this pull request
Sep 14, 2019
This will just generate a manifest in the current directory. The contents will be the same as for initializing a library package. That means the contents will likely not match the filesystem layout, but I think that is OK, this will still make it easier to add a manifest to an existing project. We can improve it in the future and make the generated content based on what is actually there on the filesystem. rdar://problem/50347943
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will just generate a manifest in the current directory. The contents will be the same as for initializing a library package.
That means the contents will likely not match the filesystem layout, but I think that is OK, this will still make it easier to add a manifest to an existing project. We can improve it in the future and make the generated content based on what is actually there on the filesystem.
rdar://problem/50347943