Implement Lock.swift on Windows #2080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aciidgh
reviewed
Apr 12, 2019
Sources/Basic/Lock.swift
Outdated
| /// | ||
| /// Note: This method can throw if underlying POSIX methods fail. | ||
| public func lock() throws { | ||
| #if os(Windows) |
Contributor
There was a problem hiding this comment.
Minor note on indenting:
#ifstatements should be indented two-space less than the regular code. See example: https://github.com/apple/swift-package-manager/blob/master/Sources/PackageDescription4/Package.swift#L68- SwiftPM uses 4-space indent for regular code.
- When breaking a method into multiple lines, indent the parameters to the left of the call: Ex: https://github.com/apple/swift-package-manager/blob/master/Sources/Workspace/Workspace.swift#L370
aciidgh
reviewed
Apr 12, 2019
Contributor
aciidgh
left a comment
aciidgh
left a comment
There was a problem hiding this comment.
Thanks! Looks great, just left some minor notes on indenting.
Contributor
Author
|
Fixed up the indenting |
Contributor
|
@swift-ci smoke test |
Contributor
|
@swift-ci smoke test linux |
unnamedd
reviewed
Apr 13, 2019
| public final class FileLock { | ||
| /// File descriptor to the lock file. | ||
| #if os(Windows) | ||
| private var h: HANDLE? |
Contributor
There was a problem hiding this comment.
Why not at least handle instead of h for this variable?
Contributor
There was a problem hiding this comment.
Renaming to handle would be nice to have. Feel free to make a PR :)
unnamedd
reviewed
Apr 13, 2019
| #if os(Windows) | ||
| private var h: HANDLE? | ||
| #else | ||
| private var fd: CInt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.