Skip to content

Conversation

@hartbit
Copy link
Contributor

@hartbit hartbit commented Dec 10, 2018

Previously, we would re-update the progress animation with the previous description when a command with shouldShowStatus returning false starts. Now, with the new build animation, it makes more sense to completely disregard those commands, both in the counting and the output. Yams now builds with the following output:

[1/7] Compiling CYaml src/writer.c
[2/7] Compiling CYaml src/parser.c
[3/7] Compiling CYaml src/reader.c
[4/7] Compiling CYaml src/emitter.c
[5/7] Compiling CYaml src/api.c
[6/7] Compiling CYaml src/scanner.c
[7/7] Compiling Swift Module 'Yams' (16 sources)

@hartbit hartbit requested a review from neonichu December 10, 2018 22:33
@hartbit hartbit added the ready Author believes the PR is ready to be merged & any feedback has been addressed label Dec 10, 2018
@hartbit
Copy link
Contributor Author

hartbit commented Dec 10, 2018

@swift-ci please smoke test

Copy link
Contributor

@neonichu neonichu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hartbit hartbit merged commit 28ff8c0 into swiftlang:master Dec 11, 2018
@hartbit hartbit deleted the fix-duplicate-build-output branch January 3, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Author believes the PR is ready to be merged & any feedback has been addressed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants