[bootstrap] Replace optparse with argparse (NFC) #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilities/bootstrap
Outdated
| args = parser.parse_args() | ||
|
|
||
| # When invoked via Xcode, it will automatically be passed a "build action". | ||
| if len(args) == 0: |
There was a problem hiding this comment.
Oops, my bad--I hadn't caught this aspect of the argument parsing. This replacement probably won't work as-is--let me keep working on this.
optparse was marked deprecated as of Python 2.7. Use its replacement, argparse. It comes with some handy features that make setting up the argument parsing a tad simpler.
|
LGTM, aside from the one comment I made on the commit. |
modocache
referenced
this pull request
in modocache/swift-package-manager
Feb 20, 2016
optparse was marked deprecated as of Python 2.7. Use its replacement, argparse. It comes with some handy features that make setting up the argument parsing a tad simpler.
|
@ddunbar I've addressed your comment: modocache@b93a048#commitcomment-16219249 -- thanks for the quick reviews!! 💨 |
|
Looks good, thanks! |
ddunbar
added a commit
that referenced
this pull request
Feb 20, 2016
[bootstrap] Replace optparse with argparse (NFC)
aciidgh
pushed a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
[tests] Add explicit test for synthetic edges on directory tree nodes.
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
optparse was marked deprecated as of Python 2.7. Use its replacement, argparse. It comes with some handy features that make setting up the argument parsing a tad simpler.
Why merge this pull request?
Besides the fact that optparse is deprecated and no longer maintained, it also does not support features argparse does. The full list is here: https://www.python.org/dev/peps/pep-0389/#why-aren-t-getopt-and-optparse-enough
What downsides are there to merging this pull request?
One could argue that optparse is working out just fine for this project for now, and that a change this large confuses
git blametoo much to be worth it.