-
Notifications
You must be signed in to change notification settings - Fork 243
Installation guide improvements (especially for Windows) #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
146d972
to
e3d9494
Compare
e3d9494
to
6d1532b
Compare
CC @shahmishal. |
This looks great, I would also like to have @compnerd review the changes. |
1fe88a2
to
166e726
Compare
2b37d8e
to
cb7d14a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, I really like the splitting up of the rules into individual files. This makes it way better.
Secondly, I like the touch up with the warning class, it highlights those bits better.
Aside from the minor editorial bit, the Windows changes are a welcome change and look good to me.
66d725d
to
0f5f53e
Compare
@swift-ci test |
Anyone to merge? |
@shahmishal @compnerd Can you help to merge this? |
@stevapple I wish I could, but I don't have that right. Mishal is out for a bit. Perhaps @tomerd can help? |
I'll let @shahmishal merge when back |
We see increased numbers of posts regarding Windows installation on Swift Forums these days, so I wonder if @shahmishal can be back soon to avoid more users being confused. If Mishal is not available in a short time, may @tomerd merge it on behalf? |
LGTM! Thanks |
Thanks for all this great work! @shahmishal and @stevapple, if it's not too late, might you have a look at these and consider?
or reply as to why they won't be addressed? Also, prior to the recent changes, the Getting Started page had an example of using LLDB, as part of the install. Did that get dropped? if so, could it be restored? Or, where did that get moved to? Thanks! |
cc @compnerd @stevapple ^^ |
This PR refines the installation guides to make it nicer and clearer, especially for Windows.
Motivation:
The Windows installation guide now have WinGet and Scoop part messed up. Different installation options should be arranged into separate source files like the Linux ones.
Modifications:
_winget.md
,_scoop.md
and_traditional.md
from/install/windows/index.md
;/install
;batch
instead ofcmd
) and PowerShell (powershell
instead ofpwsh
);/download
that are referenced nowhere.Result:
/install/windows
page is updated for accuracy and appearance, and the sources are structured more clearly./download
are removed.