Skip to content

[Content improvements] Update icons and placeholder image #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2023
Merged

[Content improvements] Update icons and placeholder image #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd15e0a
Update image assets
kaishin May 5, 2023
535994a
Fix description alignment
kaishin May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified assets/images/getting-started/article-thumbnail.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion assets/images/landing-page/hiker.svg
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions assets/images/landing-page/signs.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 1 addition & 2 deletions assets/stylesheets/pages/_getting-started.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

.go-further-list {
$grid-breakpoint: 1000px;
list-style: none;
Expand All @@ -24,7 +23,7 @@
padding-top: 0;
}

p {
.description {
flex-grow: 1;
color: var(--color-secondary-label);
}
Expand Down
19 changes: 13 additions & 6 deletions assets/stylesheets/pages/_landing.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

.why-swift-list {
list-style: none;
padding-left: 0;
Expand Down Expand Up @@ -71,22 +70,30 @@
color: var(--color-fill);
text-decoration: none;

img {
filter: invert(1);
}

.latest-release-container {
span {
border-color: var(--color-fill);
}
}

img {
filter: invert(1);

@media (prefers-color-scheme: dark) {
filter: none;
}
}
}

img {
height: 64px;
width: 64px;
display: block;
margin: 0 auto;

@media (prefers-color-scheme: dark) {
filter: invert(1);
}
}
}
}
Expand All @@ -95,7 +102,7 @@
.latest-release-container {
span {
padding: .2rem .5rem;
border: 2px solid var(--color-text);
border: 2px solid currentColor;
font-weight: bold;
border-radius: 4px;
}
Expand Down
4 changes: 2 additions & 2 deletions getting-started/_go-further.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ Ready to dive deeper? Here are some hand-picked resources covering about various
{% endif %}

<h3>{{ resource.title }}</h3>
<p class="description">
<div class="description">
{{ resource.description | markdownify }}
</p>
</div>

<a href="{{ resource.content_url }}" class="cta-secondary{% if resource.external %} external" target="_blank"{% else %}"{% endif %}>
{% if resource.content_type == "video" %}
Expand Down
2 changes: 1 addition & 1 deletion index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Swift is a general-purpose programming language built using a modern approach to

<li>
<a href="/getting-started">
<img src="/assets/images/landing-page/hiker.svg" />
<img src="/assets/images/landing-page/signs.svg" />
Get started
</a>
</li>
Expand Down