libllbuild: make the library static and internalise it #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please smoke test |
compnerd
changed the title
|
@swift-ci please smoke test |
|
CC: @etcwilde @DougGregor |
compnerd
added a commit
to compnerd/swift-installer-scripts
that referenced
this pull request
Dec 30, 2022
This has been made static with swiftlang/swift-llbuild#852. Adjust the packaging rules accordingly.
This was referenced Dec 30, 2022
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
Ping here as merging #859 alone is breaking the Windows build |
|
@swift-ci please smoke test |
|
@swift-ci test Windows |
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
compnerd
changed the title
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
Rather than emitting `libllbuild` as a dynamic library, expose it as a static library. This is used by a single user (`llbuildSwift`), and thus allows for simplification of the distribution. We no longer export libllbuild as the clients are using llbuildSwift. Because the module is not imported as `@_implementationOnly`, we need to expose the include path for `libllbuild` to clients of `llbuildSwift`.
|
@swift-ci please smoke test |
jakepetroules
approved these changes
Feb 17, 2023
This was referenced Feb 17, 2023
compnerd
added a commit
to compnerd/swift-driver
that referenced
this pull request
Feb 19, 2023
The libllbuild library has been converted into a static product and interalised into libllbuildSwift. This avoids the distribution issues here. Remove the library from the install set.
compnerd
added a commit
to swiftlang/swift-driver
that referenced
this pull request
Feb 20, 2023
Utilities: adjust install rules for swiftlang/swift-llbuild#852
compnerd
added a commit
to swiftlang/swift-installer-scripts
that referenced
this pull request
Feb 20, 2023
This has been made static with swiftlang/swift-llbuild#852. Adjust the packaging rules accordingly.
finagolfin
added a commit
to finagolfin/swift-llbuild
that referenced
this pull request
Mar 4, 2023
… statically linked Now that libllbuildSwift is statically linked against libllbuild with swiftlang#852, remove the runpath and don't install it. Also, the Android build started failing, so set the appropriate flag for it to work again.
johari
pushed a commit
that referenced
this pull request
Mar 15, 2023
… statically linked Now that libllbuildSwift is statically linked against libllbuild with #852, remove the runpath and don't install it. Also, the Android build started failing, so set the appropriate flag for it to work again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert libllbuild into static and avoid exporting the library for use in other projects. The expected clients are only reliant on llbuildSwift. This overall saves some space (~20K). Additionally, it will simplify the redistribution in the toolchain by reducing the number of shared libraries while saving space.