[Testing] Don't strip Windows NT prefix from cwd #1511
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well this speculative fix looks to be causing more test failures here, I'll just open up a revert to test instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect stripping the NT prefix from
FileManager.currentDirectoryPathmight be causing test failures in swift-corelibs-foundation.The file system representation of a file
URLinitialized withFileManager.default.currentDirectoryPathappears to be 5 characters too short. Will add better logging to the tests in swift-corelibs-foundation and test with this PR to see if this resolves it and to get more info.