[Implementation] ProgressManager v6 implementation #1468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
chloe-yeo
force-pushed
the
implementation/progress-manager
branch
from
663189d to
e487895
Compare
|
@swift-ci please test |
chloe-yeo
force-pushed
the
implementation/progress-manager
branch
2 times, most recently
from
e487895 to
28c44d7
Compare
|
@swift-ci please test |
chloe-yeo
force-pushed
the
implementation/progress-manager
branch
from
b76985d to
8fc50e2
Compare
|
@swift-ci please test |
chloe-yeo
force-pushed
the
implementation/progress-manager
branch
from
8fc50e2 to
64037e3
Compare
|
@swift-ci please test |
chloe-yeo
force-pushed
the
implementation/progress-manager
branch
from
64037e3 to
3baa7d6
Compare
chloe-yeo
force-pushed
the
implementation/progress-manager
branch
from
3baa7d6 to
e695360
Compare
|
@swift-ci please test |
chloe-yeo
force-pushed
the
implementation/progress-manager
branch
from
e695360 to
20c03d4
Compare
|
@swift-ci please test |
chloe-yeo
changed the title
restore conflict files Restore files to 26.E version Restore files to 26.E version restore preferences.h file restore preferences.m file restore attributedString file revert attributed string remove additional lines change to UInt64 where needed add if FOUNDATION_FRAMEWORK in relevant areas add if FOUNDATION_FRAMEWORK in relevant areas more #FOUNDATION_FRAMEWORK check remove exclusion from Internationalization typo
change interop variables into an enum reorder interopType switch statements move interop switch-case into enum change Throughput and fileURL Summary types remove old unused calls introduce terminate method requirement + rewrite implementation for additional property change additional property string summary to [String] change string type to use String? and [String?] add propertiesURL as available additional property type formatting for readability add propertiesUInt64 as available additional property type deinit test for additional properties + fix for deinit fractionCompleted calculation edit test to test deinit behavior for EstimatedTimeRemaining replace redundant deinit complete(count:) call with mark dirty + add tests for deinit bahavior more deinit tests additional unit tests for deinit behavior separate string additional properties into retaining vs non-retaining version add custom URL property unit tests add custom UInt64 property unit tests update documentation for additional properties methods updated initializer draft additional property observation fix establish keypaths for fileCount + rename terminate to finalSummary add observationRegistrar access calls add observationRegistrar withMutation calls add accessObservation to withProperties remove fileURL Enhancements for Additional Properties
chloe-yeo
force-pushed
the
implementation/progress-manager
branch
from
20c03d4 to
ae65b08
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest ProgressManager implementation.