build: adjust the autolink library for Windows #1312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building statically, ensure that we prefix the Swift libraries with the correct prefix to permit static linking of the libraries.
|
@swift-ci please test |
jmschonfeld
reviewed
May 22, 2025
jmschonfeld
approved these changes
May 22, 2025
|
Running the build, but unlikely to catch anything as we are not doing enough of the static library builds. |
Looks like maybe this did break the Windows CMake build? |
|
Yeah, because we weren't building Synchronization. I've added that and am going to re-try. |
jmschonfeld
added a commit
to jmschonfeld/swift-foundation
that referenced
this pull request
Jul 9, 2025
This reverts commit 5d54b93.
nate-chandler
pushed a commit
that referenced
this pull request
Jul 9, 2025
jmschonfeld
added a commit
that referenced
this pull request
Jul 16, 2025
jmschonfeld
added a commit
that referenced
this pull request
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building statically, ensure that we prefix the Swift libraries with the correct prefix to permit static linking of the libraries.