[Base64] Add new encoding options #1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Proposal: #1156 |
itingliu
reviewed
Aug 20, 2025
| public static let endLineWithLineFeed = Base64EncodingOptions(rawValue: 1 << 5) | ||
|
|
||
| /// Use the base64url alphabet to encode the data | ||
| @available(FoundationPreview 6.2, *) |
Contributor
There was a problem hiding this comment.
We'll need to update this to 6.3 since we've passed 6.2. Just so we don't forget we'll want to update the proposal too
fabianfett
force-pushed
the
ff-add-new-encoding-options
branch
from
31a85fa to
671392f
Compare
Contributor
|
@swift-ci please test |
Contributor
Author
|
@itingliu Merge? |
Contributor
|
@fabianfett There are build errors when building with Currently I'm working on a fix for that. I'd like to resolve that together with merging this, though if it turns out to be more complicated than I expected I'll come back to merge this and handle that in a follow up. |
itingliu
added a commit
to itingliu/swift-foundation
that referenced
this pull request
Sep 11, 2025
… Add new encoding options) (#3418) Signed-off-by: Tina Liu <[email protected]> Co-authored-by: Fabian Fett <[email protected]>
itingliu
added a commit
to itingliu/swift-foundation
that referenced
this pull request
Sep 11, 2025
Move the new options out of `#if !FOUNDATION_FRAMEWORK` block
itingliu
added a commit
that referenced
this pull request
Sep 11, 2025
itingliu
added a commit
to itingliu/swift-foundation
that referenced
this pull request
Sep 12, 2025
itingliu
added a commit
to itingliu/swift-foundation
that referenced
this pull request
Sep 12, 2025
itingliu
added a commit
that referenced
this pull request
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for pitch