Implement AttributedString UTF8 and UTF16 views #1066
Conversation
jmschonfeld
added
enhancement
jmschonfeld
force-pushed
the
attrstr/utf8-utf16
branch
from
60ed61e to
115ac2d
Compare
jmschonfeld
requested review from
iCharlesHu,
itingliu,
lorentey and
parkera
|
@swift-ci please test |
| _range = range | ||
| } | ||
|
|
||
| public init() { |
There was a problem hiding this comment.
Is this intentionally public? It wasn't included in the proposal. I don't think you can init a String.UTF16View either.
There was a problem hiding this comment.
Good call, this was copied from the CharacterView and UnicodeScalarView code, but I didn't include it in the proposal since there's no need to ever create this yourself especially since it's immutable - I'll remove this from the implementation
|
|
||
| public func index(before i: AttributedString.Index) -> AttributedString.Index { | ||
| precondition(i >= startIndex && i <= endIndex, "AttributedString index out of bounds") | ||
| let j = Index(_guts.string.utf8.index(before: i._value)) |
There was a problem hiding this comment.
Does this throw if i == startIndex? I believe calling string.utf8.index(before: string.utf8.startIndex) throws the index out of bound error. If so, should we just enforce this at the precondition above?
There was a problem hiding this comment.
We still do hit a precondition from swift-collections:
_RopeModule/BigString+Contents.swift:292: Precondition failed: Can't advance below start index
But we might as well account for this here, good call - I'll update the above >= to be >
|
@swift-ci please test |
2 participants
This adds a new UTF-8 and UTF-16 view to
AttributedString, vending APIs similar to the underlyingBigString's UTF-8 and UTF-16 view