Migrate generate-pipeline to a SwiftPM build tool plug-in.
#416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The biggest change that isn't just the plug-in use itself is how we detect opt-in rules now. The previous version "cheated" by linking the rules themselves into `generate-pipeline` and then used some dynamic class lookup to get the actual value at runtime. This was replaced with a syntax tree scan that looks for a simple `true` or `false` return value in a static/class property named `isOptIn`. (A future version of swift-format should probably use compile-time constants for this property, when that's officially supported.)
|
cc @dylansturg |
dylansturg
approved these changes
Oct 10, 2022
| @@ -1,31 +1,5 @@ | |||
| # Developing `swift-format` | |||
|
|
|||
| ## Keeping the Pipeline and Tests Updated | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest change that isn't just the plug-in use itself is how we detect opt-in rules now. The previous version "cheated" by linking the rules themselves into
generate-pipelineand then used some dynamic class lookup to get the actual value at runtime. This was replaced with a syntax tree scan that looks for a simpletrueorfalsereturn value in a static/class property namedisOptIn. (A future version of swift-format should probably use compile-time constants for this property, when that's officially supported.)