[5.7] Fix API naming mismatches from proposals #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename various APIs
Move options from RegexComponent to Regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
In the regex builder proposal, we proposed adding regex options directly on
Regexvs. onRegexComponent. In addition to changing that, the Unicode proposal for string processing proposed using the namessimpleanddefaultfor Unicode word breaking level 1 and level 2 respectfully.Scope:
This only affects client who are using the current, incorrect, API names as well as using options on
RegexComponents.Main Branch PR:
#575 and #576
Resolves:
rdar://97024624
Risk:
Low
Reviewed By:
@milseman
Testing:
Updated our current tests to use the new API names/altered them somewhat to reflect the options change on
Regex.