[ST-NNNN] Swift Testing image attachments (Windows) #2940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Aug 14, 2025
This PR tweaks the Windows image attachments API to match what is proposed in swiftlang/swift-evolution#2940.
Merged
2 tasks
grynspan
force-pushed
the
jgrynspan/windows-image-attachments
branch
5 times, most recently
from
b70ceb4 to
67f15a2
Compare
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Aug 15, 2025
) This PR tweaks the Windows image attachments API to match what is proposed in swiftlang/swift-evolution#2940. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
grynspan
force-pushed
the
jgrynspan/windows-image-attachments
branch
from
67f15a2 to
b30b24a
Compare
grynspan
changed the title
grynspan
commented
Sep 1, 2025
proposals/testing/NNNN-image-attachments-in-swift-testing-windows.md
Outdated
Show resolved
Hide resolved
grynspan
commented
Sep 1, 2025
proposals/testing/NNNN-image-attachments-in-swift-testing-windows.md
Outdated
Show resolved
Hide resolved
grynspan
commented
Sep 1, 2025
| /// the documentation for the [`IWICBitmapEncoder`](https://learn.microsoft.com/en-us/windows/win32/api/wincodec/nn-wincodec-iwicbitmapencoder) | ||
| /// class. | ||
| public init(_ clsid: CLSID, encodingQuality: Float = 1.0) | ||
| } |
There was a problem hiding this comment.
I should also add support for creating an instance of this type from a container format GUID:
public init(containerFormatGUID guid: GUID, encodingQuality: Float = 1.0)
grynspan
force-pushed
the
jgrynspan/windows-image-attachments
branch
from
cd7ffd5 to
f3dab6f
Compare
Add pitch link
grynspan
force-pushed
the
jgrynspan/windows-image-attachments
branch
from
f3dab6f to
21553ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.