Skip to content

[5.6] Update 5.5-specific manifest dependencies to 5.6 #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jan 4, 2022

This brings [email protected] up to parity with recent change in #929

@artemcm artemcm requested review from tomerd and abertelrud January 4, 2022 19:11
@abertelrud
Copy link

abertelrud commented Jan 4, 2022

Thanks, @artemcm!

To elaborate here, the original change modified the core manifest, but if building with a new enough SwiftPM, the version-specific manifest would be used instead. The original PR should have modified both in tandem.

@abertelrud
Copy link

One more thought: since Package.resolved is checked in, should that update be included also in this diff?

@artemcm artemcm force-pushed the update-5.5-dependencies-to-5.6 branch from 93de729 to 9042bfa Compare January 4, 2022 19:39
@artemcm
Copy link
Contributor Author

artemcm commented Jan 4, 2022

One more thought: since Package.resolved is checked in, should that update be included also in this diff?

Yeah, it makes sense to update that here also. Now included in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants