Tests: improve native path representation #940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than hardcoding the paths and the path separator, we now compute the actual locations to ensure that we can correctly represent the path representation natively on the target. This enables the correct representation on Windows.
|
@swift-ci please test |
compnerd
commented
Dec 18, 2021
| @@ -27,6 +27,14 @@ private func executableName(_ name: String) -> String { | |||
| #endif | |||
| } | |||
|
|
|||
| private func rebase(_ arc: String, at base: AbsolutePath) -> String { | |||
There was a problem hiding this comment.
If you have a better name for this function, please suggest it. I'm not tied to it, but this was the best I could come up with.
|
@cltnschlosser @artemcm - I'd like to get this merged as it unblocks another set of changes. |
This was referenced Dec 20, 2021
cltnschlosser
approved these changes
Dec 20, 2021
artemcm
approved these changes
Dec 20, 2021
Correct. The Unix absolute path |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than hardcoding the paths and the path separator, we now compute
the actual locations to ensure that we can correctly represent the path
representation natively on the target. This enables the correct
representation on Windows.