Skip to content

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Sep 21, 2021

Cherry-pick of #843

  • Explanation: This form causes Swift's underlying Clang invocation to take different code-paths when loading pre-built PCM dependencies, which is not affected on whether the compiler is in emit-pre-built-header mode.
  • Risk: Low
  • Reviewed by: @nkcsgexi
  • Testing: Automated tests modified to capture the new behavior

Workaround for rdar://83309762

…nd Clang issue with explicit builds and emit-PCH

This form causes Swift's underlying Clang invocation to take different code-paths when loading pre-built PCM dependencies, which is not affected on whether the compiler is in emit-pre-built-header mode.

Workaround for rdar://83309762
@artemcm artemcm requested a review from nkcsgexi September 21, 2021 18:32
@artemcm artemcm requested a review from a team as a code owner September 21, 2021 18:32
@artemcm
Copy link
Contributor Author

artemcm commented Sep 21, 2021

@swift-ci please test

@artemcm artemcm merged commit 012962e into swiftlang:release/5.5 Sep 21, 2021
@artemcm artemcm deleted the 55WorkaroundClangCodePathEMB branch September 21, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants