[Incremental] Fix clean build quadratic performance bug #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR is my preferred fix for the issue addressed in #742 |
Contributor
Author
|
@swift-ci please test |
Sources/SwiftDriver/IncrementalCompilation/ModuleDependencyGraphParts/DependencySource.swift
Outdated
Show resolved
Hide resolved
Contributor
cltnschlosser
left a comment
cltnschlosser
left a comment
There was a problem hiding this comment.
Still not super familiar with it all, but most of it makes sense to me now.
Sources/SwiftDriver/IncrementalCompilation/ModuleDependencyGraph.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftDriver/IncrementalCompilation/ModuleDependencyGraph.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftDriver/IncrementalCompilation/ModuleDependencyGraph.swift
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@swift-ci please test |
added 14 commits
July 8, 2021 18:07
davidungar
force-pushed
the
fix-multi-swiftmodule-read
branch
from
86e4305 to
a7030d7
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@cltnschlosser @artemcm @CodaFi , I think this is now ready for a review. Would you care to take a look? It should fix the clean build regression issue in a principled fashion. |
Contributor
Author
|
@swift-ci please test |
CodaFi
approved these changes
Jul 9, 2021
Contributor
CodaFi
left a comment
CodaFi
left a comment
There was a problem hiding this comment.
LGTM. For 5.5, we could take just the currency cache it seems.
| /// Try to read and integrate an external dependency. | ||
| /// Return nil if it's not incremental, or if an error occurs. | ||
| /// | ||
| /// Return: nil if an error occurs, or the set of directly affected nodes. |
| /// Compute the reason for (non-incrementally) invalidating nodes | ||
| /// | ||
| /// Parameter integrand: The exernal dependency causing the invalidation | ||
| /// Returns: nil if no invalidation is needed, otherwise the reason. |
CodaFi
reviewed
Jul 9, 2021
| // in a as-yet-unread swiftdeps file. | ||
| // | ||
| // Instead, just compile everything. It's OK to be unsound then because every file will be compiled anyway. | ||
| return bulidEmptyGraphAndCompileEverything() |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@CodaFi Thank you for your prompt review. Let's talk offline about Swift 5.5, I want to get your thoughts on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status quo reads every
swiftmodulefile for every input file. This PR fixes that. It is trickier than it seems because, when incremental imports are disabled, every time an initialswiftdepsfile is processed, invalidation must happen for every (changed)swiftmodulereferenced. So, this fix involves a larger reorganization that it would seem at first blush.I've tried to include enough comments, etc., so that this code should be understandable.