Add support for -lto_library linker flag #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to specify a particular LTO library on Darwin.
Contributor
Author
artemcm
approved these changes
Jul 6, 2021
Contributor
artemcm
left a comment
artemcm
left a comment
There was a problem hiding this comment.
This change looks good to me, thank you @jslegendre.
Please make sure that the Options.swift file is generated using the automated procedure described here:
https://github.com/apple/swift-driver#rebuilding-optionsswift
Contributor
|
@swift-ci please test |
Contributor
|
@swift-ci please test |
Contributor
Author
|
@artemcm Apologies for the oversight. Should be all set now. The relevant PR which adds this flag to Options.td is still open here swiftlang/swift#38264 |
Contributor
Author
|
@artemcm Anything else I should do now the tests have passed? |
Contributor
Author
|
swiftlang/swift#38264 has been merged. This should be good to go. |
Contributor
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to specify a particular LTO library on Darwin.