[5.5] Refactor IncrementalCompilationState to compute initial state before job-generation.
#634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
force-pushed
the
CherryPickIncrementalRefactor
branch
2 times, most recently
from
2c16ef6 to
0935797
Compare
Contributor
Author
|
@swift-ci please test |
…e job-generation. In the near future, planning of `PrecompileModuleDependenciesJobs`, for explicit module dependencies, will require access to the incremental state in order to incrementalize expensive actions such as dependency scanning. This change refactors the creation of incremental compilation state in order to move computation of the initial state (dependency graph) to occur before job-generation. The first wave of jobs is then computed after job-generation, using the initial state, and the set of jobs in the plan, as input. - Separate `InitialIncrementalStateComputer` to run early, by the `Driver`, to compute the dependency graph and the set of changed inputs. Rename `InitialIncrementalStateComputer` into `IncrementalDependencyAndInputSetup`. - Introduce `FirstWaveComputer` which the constructor of the `IncrementalCompilationContext` uses to compute the `mandatoryJobsInOrder` set of jobs the executors *must* run.
artemcm
force-pushed
the
CherryPickIncrementalRefactor
branch
from
0935797 to
4b4e35a
Compare
Contributor
Author
|
@swift-ci please test |
akyrtzi
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cherry-pick of: #621
In the near future, planning of
PrecompileModuleDependenciesJobs, for explicit module dependencies, will require access to the incremental state in order to incrementalize expensive actions such as dependency scanning.This change refactors the creation of incremental compilation state in order to move computation of the initial state (dependency graph) to occur before job-generation.
The first wave of jobs is then computed after job-generation, using the initial state, and the set of jobs in the plan, as input.
InitialIncrementalStateComputerto run early, by theDriver, to compute the dependency graph and the set of changed inputs. RenameInitialIncrementalStateComputerintoIncrementalDependencyAndInputSetup.FirstWaveComputerwhich the constructor of theIncrementalCompilationContextuses to compute themandatoryJobsInOrderset of jobs the executors must run.