Put the output of the (Linux) autolink step in the same place as the .o files #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
| let plannedJobs = try! driver.planBuild() | ||
| let autolinkExtractJob = plannedJobs | ||
| .filter { $0.kind == .autolinkExtract } | ||
| .first! |
There was a problem hiding this comment.
Tiny nit: Can you use try XCTUnwrap(...) instead? Just so that if this ends up nil, it fails the test rather than crashing.
There was a problem hiding this comment.
Thanks! Great catch, didn't think about XCTUnwrap.
harlanhaskins
approved these changes
Nov 12, 2020
|
@swift-ci please test |
Comment on lines
+565
to
+566
| .filter { $0.kind == .autolinkExtract } | ||
| .first) |
There was a problem hiding this comment.
This is test code so it doesn't really matter, but I like when people point things like this out to me.
You can use first(where:) https://developer.apple.com/documentation/swift/array/1848165-first to avoid iterating the whole array in cases like this, instead of doing filter then first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the legacy driver, put the output of the autolink step in the same place as the .o files, instead of in a temp directory. That way, we could possibly omit this step in the future in an incremental build.
rdar://70961296