[-debug-module-path] Prefer the moduleOutputInfo.output path if avail… #2012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
adrian-prantl
force-pushed
the
eng/PR-164524241
branch
3 times, most recently
from
66c6b94 to
d9c3e6d
Compare
Contributor
Author
|
@swift-ci test |
…able. While testing the LLDB support for enhanced module tracking I noticed that the driver currently always uses a relative path for -debug-module-path, which is an obvious problem when compiling in a different directory, or if the swift module output is in a different path than the object file output. This patch addresses this by preferring moduleOutputInfo.output if available. rdar://164524241
adrian-prantl
force-pushed
the
eng/PR-164524241
branch
from
d9c3e6d to
2ee2835
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
Hmm |
artemcm
approved these changes
Nov 14, 2025
Contributor
|
@swift-ci test Windows platform |
Contributor
Author
|
@swift-ci test Windows platform |
Contributor
Author
|
Windows failed to CMake Docc... |
cachemeifyoucan
approved these changes
Nov 14, 2025
Contributor
Author
|
@swift-ci test windows |
3 similar comments
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test windows |
Member
|
@adrian-prantl Seems like the new assertion is failing on the CI now, would you mind taking a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…able.
While testing the LLDB support for enhanced module tracking I noticed that the driver currently always uses a relative path for -debug-module-path, which is an obvious problem when compiling in a different directory, or if the swift module output is in a different path than the object file output. This patch addresses this by preferring
moduleOutputInfo.outputif available.rdar://164524241