[6.0🍒] Resolve main executable symlink when looking up driver-adjacent subcommand binaries #1606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmand binaries Resolves swiftlang/swift#70932
|
@swift-ci test |
|
@swift-ci test Windows platform |
nkcsgexi
approved these changes
May 15, 2024
|
@swift-ci test macOS platform |
|
@swift-ci test |
|
Is there a plan to merge this into 6.0? |
|
sorely needed for |
|
@swift-ci test Windows platform |
|
This should really get merged in - I'm surprised there are not more folks chiming in! |
|
This has blocked me from trying out swift 6 for months so yes please merge this. |
nkcsgexi
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #1583
Explanation: As per swiftlang/swift#70932, when swift-driver is installed via a symlink, it is not able to correctly resolve adjacent tool binaries by following their corresponding symlinks. This is a regression from the old, legacy C++ driver. This change fixes this behavior by having the driver resolve its own path if it is a symlink, first.
Risk: Low. Cases where the added code takes effect were previously not working.
Testing: Expected behavior validated manually by implementor and issue originator (on
main)Resolves swiftlang/swift#70932