Skip to content

Decrease the number of padding bytes in the Node Struct so it fits a lower quanta #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Decrease the number of padding bytes in the Node Struct so it fits a lower quanta #1580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions Sources/SwiftDriver/IncrementalCompilation/ModuleDependencyGraphParts/Node.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ extension ModuleDependencyGraph {
/*@_spi(Testing)*/ public var key: DependencyKey { keyAndFingerprint.key }
/*@_spi(Testing)*/ public var fingerprint: InternedString? { keyAndFingerprint.fingerprint }

/// When integrating a change, the driver finds untraced nodes so it can kick off jobs that have not been
/// kicked off yet. (Within any one driver invocation, compiling a source file is idempotent.)
/// When reading a serialized, prior graph, *don't* recover this state, since it will be a new driver
/// invocation that has not kicked off any compiles yet.
@_spi(Testing) public private(set) var isTraced: Bool = false

/// Each Node corresponds to a declaration, somewhere. If the definition has been already found,
/// the `definitionLocation` will point to it.
/// If uses are encountered before the definition (in reading swiftdeps files), the `definitionLocation`
Expand All @@ -46,11 +52,6 @@ extension ModuleDependencyGraph {
/// compilation.

@_spi(Testing) public let definitionLocation: DefinitionLocation
/// When integrating a change, the driver finds untraced nodes so it can kick off jobs that have not been
/// kicked off yet. (Within any one driver invocation, compiling a source file is idempotent.)
/// When reading a serialized, prior graph, *don't* recover this state, since it will be a new driver
/// invocation that has not kicked off any compiles yet.
@_spi(Testing) public private(set) var isTraced: Bool = false

private let cachedHash: Int

Expand Down