Skip to content

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Jun 21, 2020

If the swiftmodule is the primary output, we need to use the exact path provided by -o to match the behavior of the c++ driver.

Fixes Interpreter/SDK/objc_bridge.swift

@owenv
Copy link
Contributor Author

owenv commented Jun 21, 2020

@swift-ci test

@cltnschlosser
Copy link
Contributor

Must only be a few failing interpreter tests left now? I know several of the validation tests fail just due to differences in json formatting.

@owenv
Copy link
Contributor Author

owenv commented Jun 21, 2020

@cltnschlosser yeah, I think we're down to just one last failing interpreter test on macOS - shebang-env.swift. That failure seems to have something to do with how xcrun is found, but I haven't had any luck fixing it yet.

@owenv owenv merged commit e2dadc8 into swiftlang:master Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants