SwiftDriver: avoid using toSwiftString for target info
#1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C-String to Swift-String conversion would corrupt the path on Windows, where the path separator would get dropped. This would result in the inability to use the driver due to the failure to load the standard library as the SDK would not be consulted. Directly convert the raw buffer to a `Data` for the foreign representation. Note that this also makes the code clearer as we explicitly see the copying as opposed to the use of the deprecated `String(bytesNoCopy:length:encoding:freeWhenDone:)` function. Thanks to @artemcm for the help with this!
Member
Author
|
@swift-ci please test |
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Jan 27, 2023
artemcm
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C-String to Swift-String conversion would corrupt the path on Windows, where the path separator would get dropped. This would result in the inability to use the driver due to the failure to load the standard library as the SDK would not be consulted.
Directly convert the raw buffer to a
Datafor the foreign representation. Note that this also makes the code clearer as we explicitly see the copying as opposed to the use of the deprecatedString(bytesNoCopy:length:encoding:freeWhenDone:)function.Thanks to @artemcm for the help with this!