Skip to content

Conversation

@artemcm
Copy link
Contributor

@artemcm artemcm commented May 26, 2020

As discovered by invoking the fast dependency scanner from within the driver.

@artemcm artemcm requested a review from DougGregor May 26, 2020 20:21
@artemcm artemcm force-pushed the ExplicitModuleDependencyJobTest branch from 8322ad7 to 64e8fb2 Compare May 26, 2020 20:23
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

…e dependencies

discovered by the fast dependency scanner.
@artemcm artemcm force-pushed the ExplicitModuleDependencyJobTest branch from 64e8fb2 to 28f5df3 Compare May 26, 2020 21:08
@artemcm
Copy link
Contributor Author

artemcm commented May 26, 2020

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented May 26, 2020

The test in this PR invokes the Fast Dependency Scanner (with -frontend -scan-dependencies). I suspect the CI failure is caused by the fact that the CI machine's toolchain does not yet have a sufficiently recent version of the compiler and therefore does not have the Fast Dependency Scanner. :(

@DougGregor
Copy link
Member

The test in this PR invokes the Fast Dependency Scanner (with -frontend -scan-dependencies). I suspect the CI failure is caused by the fact that the CI machine's toolchain does not yet have a sufficiently recent version of the compiler and therefore does not have the Fast Dependency Scanner. :(

@shahmishal what is the process by which the toolchain gets updated for CI on this repo? We're doing some iteration with the main swift repo

@shahmishal
Copy link
Member

It's using released compiler - Swift 5.2, I can update the job to use master nightly if that helps.

@artemcm
Copy link
Contributor Author

artemcm commented May 26, 2020

That would help a lot for this and upcoming changes.

@DougGregor
Copy link
Member

It's using released compiler - Swift 5.2, I can update the job to use master nightly if that helps.

That would be wonderful, thank you!

@DougGregor
Copy link
Member

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented May 28, 2020

@swift-ci test

1 similar comment
@DougGregor
Copy link
Member

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Jun 1, 2020

As I kept iterating on this, this PR and the test it adds got subsumed into: #113

@artemcm artemcm closed this Jun 1, 2020
@artemcm artemcm deleted the ExplicitModuleDependencyJobTest branch January 20, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants