Support -file-compilation-dir #1002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Forward the flag and its associated variable to frontend 3. Add a test case to validate that the flag is forwarded to frontend correctly 4. Update Options.swift with makeOptions
Contributor
Author
|
hello @adrian-prantl @artemcm , I hope this can be merged into Swift 5.6 branch. What's the process to request approval? Thank you. |
adrian-prantl
approved these changes
Jan 31, 2022
Contributor
adrian-prantl
left a comment
adrian-prantl
left a comment
There was a problem hiding this comment.
There's not risk of breaking anything here, since this adds a new option.
Contributor
|
@swift-ci test |
Contributor
Author
|
@adrian-prantl tests all passed, would you merge this PR for me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The origin PR is merge into main.
In short, this flag gives us identical debug info paths regardless of what location we compiled the file from.
It's a small but useful feature, and hope it can happen on Swift 5.6.
The PR to merge into Swift 5.6 in Swift is here
Resolves SR-5694.