-
Notifications
You must be signed in to change notification settings - Fork 212
Update Jammy dockerfile libstdc++ version #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jammy dockerfile libstdc++ version #340
Conversation
|
@swift-ci please test |
|
Bot Failure: |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
tomerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to do the same in other versions of ubuntu, or other distributions?
|
in any case, seems like we should also this for |
It looks like Ubuntu 20.04 uses gcc-9, so the original should be fine there. Then ubuntu 18.04 uses gcc-7/libstdc++-7-dev as its tool C++, so it would probably be a good idea to bump the versions here: https://github.com/apple/swift-docker/blob/main/5.8/ubuntu/18.04/Dockerfile#L14C19-L15
Yes, good point. |
|
Bot Failure: |
Ubuntu 22.04 tools use gcc-11 aligned C/C++ libraries and runtimes as built by the distribution. The package for gcc-9 aligned versions are available, but installing any tool (e.g libtool) from the official repositories will install gcc-11 aligned runtimes. Clang will see this version instead and go looking for the C++ headers that match the latest version of gcc, which is 11. The tools don't necessarily install the libstdc++-11 headers though, so clang will fail to find things like iostream and friends. Swift runs and builds fine with the newer C++ library, so I'm updating all 22.04-aligned swift dockerfiles with the version used by the system natively.
744ff1b to
24370b5
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@shahmishal do you know why this keeps failing on gpg keyserver? |
|
@swift-ci please test |
|
keyserver.ubuntu.com might be having connection issues |
|
I think I had the same CI issue with #337 2 months ago, so this breakage does not seem intermittent. |
|
@shahmishal wdyt? |
|
@swift-ci please test |
Jammy uses the gcc-11 aligned c/c++ libraries and runtimes, but we force-install the gcc-9 aligned versions. If you install any tools from the Ubuntu-official repositories (e.g libtool), you'll get error messages because clang will look for the C++ headers aligned with the newest gcc version (11), instead of what we installed (9), so folks need to know to manually install
libstdc++-11-devif they want to do that, which is bad.apt info for
gcc, which depends ongcc-11.rdar://109112170