Skip to content

update doc-comment file-path tests to include paths with spaces #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2022
Merged

update doc-comment file-path tests to include paths with spaces #327

merged 1 commit into from
Jul 1, 2022

Conversation

QuietMisdreavus
Copy link
Contributor

  • Explanation: Adds tests to ensure that doc comments whose filename include spaces can still properly parse.
  • Scope: No change to behavior (this already worked on the release branch)
  • Radar: rdar://96216773 (the commit is not tagged with it since the issue was wholly on the main branch)
  • Risk: None. This is only an update to tests.
  • Testing: Ensure that automated tests pass.
  • Original PR: update SymbolKit to include apple/swift-docc-symbolkit#44 #326 (This only includes the tests from that PR; the SymbolKit change is already present on this branch)
  • Reviewer: @franklinsch (He hasn't reviewed the original PR, but we chatted offline while i was working on it)

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus QuietMisdreavus merged commit d851380 into swiftlang:release/5.7 Jul 1, 2022
@QuietMisdreavus QuietMisdreavus deleted the 5.7/comment-spaces branch July 1, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklinsch franklinsch franklinsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuietMisdreavus @franklinsch