Skip to content

Conversation

@talzag
Copy link
Contributor

@talzag talzag commented Jun 27, 2022

Bug/issue #: rdar://90715477

Summary

Thread sanitizer doesn't handle SIGINT properly, and this causes the
signal-test-app to hang when tests are run under TSan. Sending SIGABRT
causes signal-test-app to exit under all circumstances.

Dependencies

None

Testing

Steps:

  1. Open the package in Xcode
  2. Select the SwiftDocC-Package scheme
  3. Select Product > Scheme > Edit Scheme...
  4. Select the Test row on the left side of the scheme editor window
  5. Select the Diagnostics tab
  6. Turn on the Thread Santizier
  7. Select Product > Test
  8. Verify that the tests complete, specifically that SignalTests.testTrappingSignal() doesn't hang.

Alternatively, run xcrun swift test --sanitize thread and verify that the test run completes.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran the ./bin/test script and it succeeded
  • Updated documentation if necessary

Thread sanitizer doesn't handle SIGINT properly, and this causes the
signal-test-app to hang when tests are run under TSan. Sending SIGABRT
causes signal-test-app to exit under all circumstances.

rdar://90715477
@talzag
Copy link
Contributor Author

talzag commented Jun 27, 2022

@swift-ci Please test

@talzag talzag merged commit 41f2ac1 into swiftlang:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants