-
Notifications
You must be signed in to change notification settings - Fork 163
Adopt new GitHub Issues Forms syntax #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ethan-kusters Could you help review this? |
|
@ethan-kusters any thoughts here? I'm not very familiar with Forms |
|
Ping @ethan-kusters. Could you help spare some time to review this? |
ethan-kusters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for investigating and opening this Kyle! Having the preview over on https://github.com/Kyle-Ye/Issue/issues was very helpful.
I just left a few thoughts on the overall formatting but I think this is already a huge improvement over what we have.
|
Resolve the comments you provide above @ethan-kusters. And you can check the updated preview over here https://github.com/Kyle-Ye/Issue/issues/new/choose |
ethan-kusters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great- just had a couple of last thoughts. Thank you!
| attributes: | ||
| label: Swift-DocC Version Information | ||
| description: The version of Swift-DocC used to reproduce this issue. | ||
| placeholder: "'5.6.0' for example, or a commit hash" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review notes for @ethan-kusters
- The render key is not supported on type: input
- The placeholder value:
'5.6.0' for example, or a commit hashmust be quoted for some reason. Otherwise, we'll get a yaml parse error.
|
@swift-ci please test |
ethan-kusters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you so much for your work on this @Kyle-Ye!
|
Just came across this when creating a new issue, so cool! Thanks @Kyle-Ye! |
Bug/issue #, if applicable: #232
Summary
Migrate existing templates over to the new format to make it easier for contributors to file bug reports and feature requests.
Test
Considering above, I have to create an empty & public repo to test this PR.
https://github.com/Kyle-Ye/Issue/issues/new/choose