Skip to content

Conversation

@Kyle-Ye
Copy link
Contributor

@Kyle-Ye Kyle-Ye commented May 29, 2022

Bug/issue #, if applicable: #232

Summary

Migrate existing templates over to the new format to make it easier for contributors to file bug reports and feature requests.

Test

  1. The yaml templet feature is currently in beta and only available on a public repo.
  2. "Issue" feature can't be tested on a forked repo. (We can't simply test it like what we did when we add swift-docc support for deploying docs to GitHub page)

Considering above, I have to create an empty & public repo to test this PR.
https://github.com/Kyle-Ye/Issue/issues/new/choose

@Kyle-Ye Kyle-Ye marked this pull request as ready for review May 29, 2022 16:29
@Kyle-Ye Kyle-Ye requested a review from ethan-kusters May 29, 2022 16:29
@Kyle-Ye Kyle-Ye added the documentation Improvements or additions to documentation label May 29, 2022
@Kyle-Ye Kyle-Ye linked an issue Jun 5, 2022 that may be closed by this pull request
@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Jun 5, 2022

@ethan-kusters Could you help review this?

@Kyle-Ye Kyle-Ye added this to the Swift 5.7 milestone Jun 6, 2022
@Kyle-Ye Kyle-Ye requested a review from franklinsch June 11, 2022 15:32
@Kyle-Ye Kyle-Ye mentioned this pull request Jun 14, 2022
3 tasks
@franklinsch
Copy link
Contributor

@ethan-kusters any thoughts here? I'm not very familiar with Forms

@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Jun 30, 2022

Ping @ethan-kusters. Could you help spare some time to review this?

Copy link
Contributor

@ethan-kusters ethan-kusters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for investigating and opening this Kyle! Having the preview over on https://github.com/Kyle-Ye/Issue/issues was very helpful.

I just left a few thoughts on the overall formatting but I think this is already a huge improvement over what we have.

@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Jul 2, 2022

Resolve the comments you provide above @ethan-kusters.

And you can check the updated preview over here https://github.com/Kyle-Ye/Issue/issues/new/choose

@Kyle-Ye Kyle-Ye requested a review from ethan-kusters July 2, 2022 01:51
Copy link
Contributor

@ethan-kusters ethan-kusters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great- just had a couple of last thoughts. Thank you!

attributes:
label: Swift-DocC Version Information
description: The version of Swift-DocC used to reproduce this issue.
placeholder: "'5.6.0' for example, or a commit hash"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review notes for @ethan-kusters

  1. The render key is not supported on type: input
  2. The placeholder value: '5.6.0' for example, or a commit hash must be quoted for some reason. Otherwise, we'll get a yaml parse error.

@Kyle-Ye Kyle-Ye requested a review from ethan-kusters July 3, 2022 10:00
@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Jul 3, 2022

@swift-ci please test

Copy link
Contributor

@ethan-kusters ethan-kusters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you so much for your work on this @Kyle-Ye!

@Kyle-Ye Kyle-Ye merged commit ed1770f into swiftlang:main Jul 4, 2022
@Kyle-Ye Kyle-Ye deleted the github-issue branch July 4, 2022 08:51
@franklinsch
Copy link
Contributor

Just came across this when creating a new issue, so cool! Thanks @Kyle-Ye!

@Kyle-Ye Kyle-Ye mentioned this pull request Aug 8, 2022
@Kyle-Ye Kyle-Ye mentioned this pull request Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt new GitHub Issues Forms syntax

3 participants