improve detection for inherited symbol references #257
Conversation
|
@swift-ci Please test |
QuietMisdreavus
force-pushed
the
origin-split
branch
from
29b16ef to
b558bac
Compare
|
@swift-ci Please test |
| // If we don't have a resolved `sourceOrigin` parent, fall back to parsing its display name | ||
|
|
||
| // Detect the path components of the providing the default implementation. | ||
| let typeComponents = originDisplayName.components(separatedBy: ".").filter({ !$0.isEmpty }) |
There was a problem hiding this comment.
Nit: The default behavior of the Swift native String.split actually does this filtering for empty components automatically: https://developer.apple.com/documentation/swift/string/split(separator:maxsplits:omittingemptysubsequences:)
| let typeComponents = originDisplayName.components(separatedBy: ".").filter({ !$0.isEmpty }) | |
| let typeComponents = originDisplayName.split(separator: ".") |
| defer { | ||
| try? FileManager.default.removeItem(at: bundleURL) | ||
| } |
There was a problem hiding this comment.
Nit: testBundleAndContext uses a test teardown block to remove any created temp files.
| defer { | |
| try? FileManager.default.removeItem(at: bundleURL) | |
| } |
There was a problem hiding this comment.
We should probably clean up all the other tests that use their own defer blocks, then; i was working off the pattern elsewhere in the file! 😅
There was a problem hiding this comment.
Yeah, I've started to clean it up as I encounter them. Here are some changes from my link resolution PR. That PR broke a lot of tests in the early stages of the integration 😅
|
I've pushed up changes for the review comments. @swift-ci Please test |
ethan-kusters
left a comment
ethan-kusters
left a comment
There was a problem hiding this comment.
Looks great. Thank you!!
QuietMisdreavus
force-pushed
the
origin-split
branch
from
e427bd2 to
9fcd568
Compare
|
Rebased onto the latest @swift-ci Please test |
rdar://93203894 Symbols for operator functions that include multiple dots (e.g. the ClosedRange `...` operator) are currently curated into an unnamed "Implementations" section due to improper string splitting behavior. This enhances the detection two ways: 1. For symbols where the "source origin" is available in our given symbol graphs, it loads the name information from the parent symbol. 2. For symbols where the "source origin" is not available, it improved the string splitting behavior by dropping empty-string components before reading names from it. This allows Comparable and Equatable implementations to curate their inherited operators properly.
QuietMisdreavus
force-pushed
the
origin-split
branch
from
9fcd568 to
f2d37da
Compare
|
Rebased. @swift-ci Please test |
3 participants
Bug/issue #, if applicable: rdar://93203894
Summary
Symbols for operator functions that include multiple dots (e.g. the
ClosedRange
...operator) are currently curated into an unnamed"Implementations" section due to improper string splitting behavior.
This enhances the detection two ways:
symbol graphs, it loads the name information from the parent symbol.
the string splitting behavior by dropping empty-string components
before reading names from it.
This allows Comparable and Equatable implementations to curate their
inherited operators properly.
Dependencies
None
Testing
Steps:
....operator in theFancyProtocolsymbol graph added in this PR).Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded