[5.9] Support linkable attribute tokens #643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mportiz08
commented
May 5, 2023
mportiz08
commented
- Explanation: Adds support for linkable attributes in Swift declarations.
- Scope: Impacts all pages with Swift declarations w/ linkable types
- Issue: rdar://108472125
- Risk: Medium, small change but impacts all Swift decls
- Testing: Added/updated unit tests and manually tested various kinds of declarations with linkable/non-linkable types and attributes
- Reviewer: @dobromir-hristov and @hqhhuang
- Original PR: Support linkable attribute tokens #636
Resolves: rdar://108472125
mportiz08
changed the title
franklinsch
approved these changes
May 9, 2023
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.