Skip to content

Conversation

@dobromir-hristov
Copy link
Contributor

Bug/issue #, if applicable: 105566775

Summary

Refactors the default sidebar width on large and ultra wide screens.

  1. Ultrawide hits when its above 1921, as Safari was going into ultrawide mode on fullhd screens.
  2. The large screen default is now a hard 400px

Dependencies

NA

Testing

  1. Open in a private tab
  2. Assert on fullHD screen it uses 400px as default width
  3. Assert on screens above that, it uses 543px

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

Copy link
Member

@marinaaisa marinaaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good, thanks!

@dobromir-hristov
Copy link
Contributor Author

@swift-ci test

@dobromir-hristov dobromir-hristov merged commit 52847fc into swiftlang:main May 8, 2023
@dobromir-hristov dobromir-hristov deleted the dhristov/r105566775-fix-default-width-on-large branch May 8, 2023 06:33
dobromir-hristov pushed a commit to dobromir-hristov/swift-docc-render that referenced this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants