feat: add a hero to the DocumentationTopic.vue #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 28, 2022
mportiz08
approved these changes
Mar 3, 2022
Contributor
Author
|
@swift-ci test |
Contributor
|
@swift-ci test |
left align hero content
Remove Hero Image from symbol pages
…move-hero-from-symbol
fix padding on small viewport
New Hero/Introduction section design: Left Align Hero Content
Fix title color with hero removed and fix extra border
…o remove-hero-from-symbol
fix spacing between hero and body
use modifier
fix title styling
fix test after var name change
remove margin top edit
New Hero/Introduction section design: Remove Dark Hero from symbol pages Fixes: rdar://89970711
Contributor
|
@swift-ci test |
Contributor
|
Manually closing as this was merged with #113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 89092590
Summary
Implements a Hero section into Docc-render, that is to be used in tandem with the new Sidebar functionality.
This PR supersedes the old - dobromir-hristov#4
Dependencies
NA
Testing
Make sure you download and unzip the
.doccarchive- SlothCreator.doccarchive.zipSteps:
VUE_APP_DEV_SERVER_PROXY=/path/to/SlothCreator.doccarchive npm run serveChecklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded